X.PagedList.Mvc.Core: Improve nullable handling for generatePageUrl #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only ever use the generatePageUrl argument (in various places) to set HTML attribute values with TagBuilder.Attributes.Add(). The latter specifically accepts nullable strings for the value. Thus, this commits adjusts the return type of the `Func<int, string>` for generatePageUrl to be nullable as well, i.e. to `Func<int, string?>`, for all affected cases. This removes nullable warnings for actual use cases like the following: @Html.PagedListPager(someModel, page => Url.Action(...), ...) Here, Url.Action returns `string?` and thus creates a nullable warning CS8603 with the implementation before this commit. Since TagBuilder.Attributes.Add() allows `string?`, though, we can be more permissive here and do so with this commit.
a-gubskiy
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only ever use the generatePageUrl argument (in various places) to set HTML attribute values with TagBuilder.Attributes.Add().
The latter specifically accepts nullable strings for the value. Thus, this commits adjusts the return type of the
Func<int, string>for generatePageUrl to be nullable as well, i.e. toFunc<int, string?>, for all affected cases.This removes nullable warnings for actual use cases like the following:
@Html.PagedListPager(someModel, page => Url.Action(...), ...)
Here, Url.Action returns
string?and thus creates a nullable warning CS8603 with the implementation before this commit. Since TagBuilder.Attributes.Add() allowsstring?, though, we can be more permissive here and do so with this commit.This has been found while testing 10.0.0-pre