Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decoding] MusicData not decoding properly #18

Closed
jsbean opened this issue Dec 20, 2018 · 1 comment
Closed

[Decoding] MusicData not decoding properly #18

jsbean opened this issue Dec 20, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@jsbean
Copy link
Member

jsbean commented Dec 20, 2018

The music-data element in MusicXML is a collection of any number of values within a set of possible types

<!ENTITY % music-data
	"(note | backup | forward | direction | attributes |
	  harmony | figured-bass | print | sound | barline | 
	  grouping | link | bookmark)*">

This is representable as an enum with associated values in Swift (really, it's a union type):

enum MusicDatum {
    case note(Note)
    case attributes(Attributes)
    ...
}

Due to CoreOffice/XMLCoder#25, arrays of enums with associated values are not yet decodable.

@jsbean jsbean added the bug Something isn't working label Dec 20, 2018
@jsbean
Copy link
Member Author

jsbean commented Jul 31, 2019

This is closed by MaxDesiatov/XMLCoder #119.

@jsbean jsbean closed this as completed Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant