-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix partially Issue 21573 - formatting floating points should be CTFE #7762
Conversation
Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7762" |
std/format.d
Outdated
@@ -2948,6 +2953,18 @@ useSnprintf: | |||
~"0000000000000000000000000000000000000000000000000000000000000000000p+0"); | |||
} | |||
|
|||
@safe unittest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this can't be pure
because of the floats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly (for my) it can be pure, while the quite similar test directly above cannot. The static
seems to make a difference here.
removed merge conflict with #7764 |
I just noticed, that CTFE can already be implemented independent of #7757 and followups. Of course, it will be limited to the part, where
snprintf is already replaced
, currently %e and %a applied to float and double.Thanks to Petar Kirov and Paul Backus for help.