Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partially Issue 21573 - formatting floating points should be CTFE #7762

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

berni44
Copy link
Contributor

@berni44 berni44 commented Jan 22, 2021

I just noticed, that CTFE can already be implemented independent of #7757 and followups. Of course, it will be limited to the part, where snprintf is already replaced, currently %e and %a applied to float and double.

Thanks to Petar Kirov and Paul Backus for help.

@berni44 berni44 requested a review from andralex as a code owner January 22, 2021 17:49
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21573 enhancement formatting floating points should be CTFE

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7762"

std/format.d Outdated
@@ -2948,6 +2953,18 @@ useSnprintf:
~"0000000000000000000000000000000000000000000000000000000000000000000p+0");
}

@safe unittest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this can't be pure because of the floats?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly (for my) it can be pure, while the quite similar test directly above cannot. The static seems to make a difference here.

@RazvanN7 RazvanN7 added the Merge:72h no objection -> merge The PR will be merged if there are no objections raised. label Jan 25, 2021
@berni44
Copy link
Contributor Author

berni44 commented Jan 25, 2021

removed merge conflict with #7764

@RazvanN7 RazvanN7 added Merge:auto-merge and removed Merge:72h no objection -> merge The PR will be merged if there are no objections raised. labels Jan 28, 2021
@dlang-bot dlang-bot merged commit 3fb4783 into dlang:master Jan 28, 2021
@berni44 berni44 deleted the format_ctfe branch February 13, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants