Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance regression introduced by PR #7285. #7346

Merged
merged 1 commit into from Jan 12, 2020
Merged

Fix performance regression introduced by PR #7285. #7346

merged 1 commit into from Jan 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2020

The global import of std.math : FloatingPointControl caused a performance regression. This PR fixes this by making the import local.

See discussion for more details.

PS: I checked, using valgrind, that this import indeed caused the regression.

@ghost ghost requested a review from andralex as a code owner January 7, 2020 10:45
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + phobos#7346"

Copy link
Contributor

@kinke kinke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loosens Phobos intra-dependencies again and is much appreciated; e.g., this previously broke usability of std.algorithm.* stuff for WebAssembly.

@ghost
Copy link
Author

ghost commented Jan 12, 2020

Wow, never had a PR with 3 approvals. ;-) Unfortunately the tests got stuck, both just not returning the positive result, as far as I can see...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants