fix bincode versioning #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumbleskates
commented
Mar 9, 2025
Comment on lines
+22
to
+26
| "version": "1" | ||
| }, | ||
| "bincode": { | ||
| "name": "bincode", | ||
| "version": "2.0.0-rc" | ||
| "version": "2" |
There was a problem hiding this comment.
these are actually semver specifications now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since bincode2 is actually updating now, we might as well clean up the versioning config a bit
previously we just hard-replaced the crate version with the version from the config, but we can instead use the
versionfield in the config there as a semver version spec that constrains which versions of the crate each feature is talking about. this way each feature will know, for example, which major version of thebincodecrate it is about, and the lookups can find the correct one in the cargo metadata info.this should fix the readme which currently has a busted link and version name for
bincode2.0.0 because it's getting replaced incorrectly