Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust-protobuf support to benchmarking #101

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

GuyLewin
Copy link
Contributor

Added support for benchmarking https://github.com/stepancheg/rust-protobuf

@GuyLewin
Copy link
Contributor Author

This error seems to be related to Bitcode, I don't think this was caused due to my changes.

@djkoloski
Copy link
Owner

I'll take a look at this after work. It looks like bitcode released a new version recently, so maybe something went wrong here.

@GuyLewin
Copy link
Contributor Author

Yeah @djkoloski fix is just to upgrade pinned version. Seems like bitcode_derive dependency was too new and became incompatible with our pinned version.
Here's a PR: #102

@GuyLewin GuyLewin force-pushed the feature/add-rust-protobuf branch from 82c002b to 5db1350 Compare February 20, 2025 18:09
@GuyLewin
Copy link
Contributor Author

@djkoloski i need to match my protoc version to the one in CI, will push a fix

@djkoloski djkoloski merged commit 2740904 into djkoloski:master Feb 20, 2025
1 check passed
@djkoloski
Copy link
Owner

Thanks for the PR! CI should finish in an hour or two.

@mumbleskates
Copy link
Collaborator

we can bump up the version of the ci protoc too if that should be affecting more than it used to be now. previously it was only used by prost to preprocess message definitions into descriptor protos. it probably makes sense to keep it within a few releases of latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants