Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Debug derives. #686

Merged
merged 2 commits into from
Jul 19, 2024
Merged

More Debug derives. #686

merged 2 commits into from
Jul 19, 2024

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Jul 17, 2024

No description provided.

@Vrixyz Vrixyz requested a review from sebcrozet July 17, 2024 09:12
Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
This adds Debug on quite large structures. Have you noticed any reduction of compilation times after this change?

@Vrixyz
Copy link
Contributor Author

Vrixyz commented Jul 18, 2024

No, I did not detect a meaningful compilation time change ; it seems to inflates the library size by 0.2MiB though:

image

(there's this weird 19 seconds timing which made me doubt but that's probably rust analyzer running indexing and other tasks slowing the whole thing down)

(I also compared with full clean and results were also similar between master and this branch.)

@Vrixyz Vrixyz merged commit 0ff5541 into dimforge:master Jul 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants