Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a clippy warning #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a clippy warning #299

wants to merge 1 commit into from

Conversation

zzl0
Copy link

@zzl0 zzl0 commented Feb 12, 2025

This diff fixes the clippy warning about manual_strip: https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip

Screenshot 2025-02-12 at 10 36 06 AM

@markbt
Copy link
Collaborator

markbt commented Mar 6, 2025

String::strip_prefix was added in 1.45 but our MSRV is 1.41. 1.45 is nearly 5 years old at this point, so perhaps we could consider bumping the MSRV. I think the reason for holding back was the version of Rust in Debian stable, so will need to check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants