Trigger all marked cronjobs #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derailed
requested changes
Mar 7, 2025
DanCocking
force-pushed
the
trigger-all-marked-cronjobs
branch
from
22732c2 to
fe2ba6e
Compare
|
@DanCocking Looks like the code is not formatted correctly. Please check linter report. |
derailed
added
enhancement
Currently, running the cronjob trigger command supports triggering the currently selected cronjob only. It would be nice if this feature supported triggering all marked cronjobs in the case that there are marked cronjobs - in a similar fashion to scaling deployments or generally deleting resources. Let's modify cronjob triggering to support the case where the user has marked multiple cronjobs in the cronjob view.
DanCocking
force-pushed
the
trigger-all-marked-cronjobs
branch
from
fe2ba6e to
8d114e9
Compare
I did think the code diff seemed ultra suspicious. Have fixed it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running the cronjob trigger command supports triggering the currently selected cronjob only. It would be nice if this feature supported triggering all marked cronjobs in the case that there are marked cronjobs - in a similar fashion to scaling deployments or generally deleting resources.
Let's modify cronjob triggering to support the case where the user has marked multiple cronjobs in the cronjob view.