Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(check/npm): move not found errors inside npm packages to tsc diagnostics #28337

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 28, 2025

Previously #28174 only handled this for npm package entrypoint and missed doing it for inside npm packages.

Confirmed fixes the original issue.

  • Come up with test case
  • Surface the not found error as a tsc diagnostic... seems it not done in this case.

Closes #27188

@dsherret dsherret changed the title fix(check): move more not found diagnostics to tsc diagnostics fix(check): move more not found errors to tsc diagnostics Feb 28, 2025
@dsherret dsherret changed the title fix(check): move more not found errors to tsc diagnostics fix(check/npm): move more not found errors to tsc diagnostics Feb 28, 2025
@dsherret dsherret changed the title fix(check/npm): move more not found errors to tsc diagnostics fix(check/npm): move not found errors inside npm packages to tsc diagnostics Feb 28, 2025
@dsherret dsherret marked this pull request as ready for review February 28, 2025 14:16
@dsherret dsherret requested a review from bartlomieju February 28, 2025 14:16
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 2a803fe into denoland:main Feb 28, 2025
18 checks passed
@dsherret dsherret deleted the fix_further_move_not_found_module_errors_to_tsc_diagnostics branch February 28, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface not found modules as diagnostics instead of erroring and failing to load
2 participants