Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): include prefix and suffix for rename edits #28327

Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix(lsp): include prefix and suffix for rename edits #28327

merged 2 commits into from
Feb 27, 2025

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #28074.

dsherret
dsherret approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit eea5eb1 into denoland:main Feb 27, 2025
18 checks passed
@nayeemrmn nayeemrmn deleted the lsp-rename-prefix-suffix branch February 28, 2025 15:49
littledivy pushed a commit that referenced this pull request Mar 5, 2025
@nayeemrmn @littledivy
fix(lsp): include prefix and suffix for rename edits (#28327)
aaea605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp: Renaming variables doesn't updated shorthand property names correctly
2 participants
@nayeemrmn @dsherret