-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext/http): Show that is also listening on localhost #28171
base: main
Are you sure you want to change the base?
Conversation
ext/http/00_serve.ts
Outdated
@@ -740,7 +740,7 @@ function serve(arg1, arg2) { | |||
} | |||
|
|||
const listenOpts = { | |||
hostname: options.hostname ?? "0.0.0.0", | |||
hostname: options.hostname ?? "localhost", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to fail a bunch of tests. It might be good to make this a display only thing.
This isn't equivalent at all. |
Thanks for the insights, I'll redo it |
With additional bit of text you mean like:
? Or just showing |
This seems like the ideal behavior to me, if you're willing to implement it. |
Closes #27722
This will show
Listening on http://0.0.0.0:8000 (accessible via http://localhost:8000)