Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: webhook timer coverage in mutate-processor test #1897

Merged
merged 5 commits into from
Mar 6, 2025
Merged

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Mar 5, 2025

Description

This is very hard to test because the Capability does not have actual bindings. Because of that the test stops here and returns early. The only meaningful tests I could do was to ensure the timer start and stop were called.

There is already too much mocking in this file I cannot get any assertions to pass for base64 calls here.

UPDATE: was able to validate the first decodeData was called by shuffling files around and mocking the call in mutate-process.test.ts. The rest of the test is untestable due to no bindings in the capabilities

Needs #1895 to pass.

Related Issue

Fixes #1892

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner March 5, 2025 18:34
@cmwylie19 cmwylie19 changed the title Mutate test chore: webhook timer coverage in mutate-processor test Mar 5, 2025
@cmwylie19 cmwylie19 marked this pull request as draft March 5, 2025 19:55
@cmwylie19 cmwylie19 marked this pull request as ready for review March 5, 2025 20:23
@samayer12 samayer12 enabled auto-merge March 6, 2025 16:23
@samayer12 samayer12 added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit 666bdb2 Mar 6, 2025
77 checks passed
@samayer12 samayer12 deleted the mutate-test branch March 6, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

increase coverage in mutate-processor
2 participants