Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve test coverage for webhook generation #1815

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

samayer12
Copy link
Contributor

@samayer12 samayer12 commented Feb 12, 2025

Description

We identified a testing gap that exists when a webhook is generated from an instance of the Assets object that has Assets.host defined. This test case addresses that gap.

NOTE: There's some tight coupling with the Assets class and the use of a massive JSON string to create our test assets object in this file. Resolving those issue are outside the scope of this PR but do need to be addressed by future work. See #1816 and #1817

Related Issue

Fixes #1723

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (9c54ecb) to head (7151e3c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1815      +/-   ##
==========================================
- Coverage   82.12%   81.59%   -0.53%     
==========================================
  Files          52       54       +2     
  Lines        2215     2239      +24     
  Branches      436      473      +37     
==========================================
+ Hits         1819     1827       +8     
+ Misses        394      383      -11     
- Partials        2       29      +27     

see 10 files with indirect coverage changes

@samayer12 samayer12 marked this pull request as ready for review February 12, 2025 21:05
@samayer12 samayer12 requested a review from a team as a code owner February 12, 2025 21:05
Copy link
Contributor

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adds test for the host

@cmwylie19 cmwylie19 added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit a69014a Feb 12, 2025
51 checks passed
@cmwylie19 cmwylie19 deleted the 1723-webhook-config-test branch February 12, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add a npx pepr dev test around the WebhookConfig that is generated
2 participants