Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename npm version command for nightlies to work #1742

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Jan 29, 2025

Description

We run npm version --no-git-tag-version "$FULL_VERSION" to update the version in package.json before a release. In Pepr Core, we accidentally had overridden that command with a custom command that we use when we publish SLSA.

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner January 29, 2025 19:51
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.76%. Comparing base (967eb05) to head (3e2d338).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1742   +/-   ##
=======================================
  Coverage   79.76%   79.76%           
=======================================
  Files          50       50           
  Lines        2120     2120           
  Branches      431      462   +31     
=======================================
  Hits         1691     1691           
+ Misses        427      401   -26     
- Partials        2       28   +26     

see 8 files with indirect coverage changes

Copy link
Contributor

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmwylie19 cmwylie19 merged commit 52bf35d into main Jan 29, 2025
47 of 48 checks passed
@cmwylie19 cmwylie19 deleted the quick-fix branch January 29, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants