Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backwards compat - open to team ideas! #1707

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Jan 22, 2025

Description

Scaffolding for backwards compatibility. @defenseunicorns/pepr-dev let me know what you think, what else we want to include.

Related Issue

Fixes #312

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner January 22, 2025 19:16
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.44%. Comparing base (5def05c) to head (7078078).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1707   +/-   ##
=======================================
  Coverage   79.44%   79.44%           
=======================================
  Files          48       48           
  Lines        2082     2082           
  Branches      428      428           
=======================================
  Hits         1654     1654           
  Misses        426      426           
  Partials        2        2           

Copy link
Contributor

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good starting point on backwards compatibility. If this relates to us going to v1.0.0 eventually, maybe we should have @maryparsons, @daveworth, and @jeff-mccoy take a look to track team intent.

@samayer12 samayer12 self-requested a review January 23, 2025 18:36
Copy link
Contributor

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding changes are left as open comments. Once resolved, we're good to merge.

@cmwylie19 cmwylie19 enabled auto-merge January 24, 2025 13:26
@cmwylie19 cmwylie19 added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 77fab89 Jan 24, 2025
48 checks passed
@cmwylie19 cmwylie19 deleted the 312-backwards-compatability branch January 24, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Backwards compatibility document
2 participants