chore: chainguard node23 is a no, so... distroless? #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btlghrants
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1684 +/- ##
=======================================
Coverage 79.52% 79.52%
=======================================
Files 48 48
Lines 2090 2090
Branches 460 460
=======================================
Hits 1662 1662
- Misses 398 426 +28
+ Partials 30 2 -28
|
cmwylie19
approved these changes
Jan 17, 2025
cmwylie19
approved these changes
Jan 17, 2025
This was referenced Jan 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
## Description The `soak.ci.yaml` uses pre-built manifests. When this [PR](#1684) merged we went to a distroless image where `node` is not in the path on the image. We need to update the args on the deployments. [Job Failure](https://github.com/defenseunicorns/pepr/actions/runs/12840693540/job/35809678165) ## Related Issue Fixes # <!-- or --> Relates to # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed Signed-off-by: Case Wylie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we can't use chainguard free because it's only node:23+ then what about building on upstream node:22 & running with distroless?
Related Issue
Relates to # 1676
Type of change
Checklist before merging