Move deep-partial type to common-types

defenseunicorns · Mar 6, 2025 · 9a0f0e6 · 9a0f0e6
1 parent d59bace
commit 9a0f0e6
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 9 deletions.
diff --git a/src/lib/common-types.ts b/src/lib/common-types.ts
@@ -96,3 +96,8 @@ export type ValidateActionResponse = {
   statusCode?: number;
   statusMessage?: string;
 };
+
+// DeepPartial utility type for deep optional properties
+export type DeepPartial<T> = {
+  [P in keyof T]?: T[P] extends object ? DeepPartial<T[P]> : T[P];
+};
diff --git a/src/lib/filter/adjudicators/bindingAdjudicators.test.ts b/src/lib/filter/adjudicators/bindingAdjudicators.test.ts
@@ -45,7 +45,7 @@ import {
   carriedLabels,
   carriesLabels,
 } from "./kubernetesObject";
-import { DeepPartial } from "../../utility-types";
+import { DeepPartial } from "../../common-types";
 import { ValidateActionResponse } from "../../common-types";
 
 describe("definesDeletionTimestamp", () => {

diff --git a/src/lib/filter/adjudicators/mismatch.test.ts b/src/lib/filter/adjudicators/mismatch.test.ts
@@ -20,7 +20,7 @@ import {
   mismatchedNamespaceRegex,
 } from "./mismatch";
 import { Event, Operation } from "../../enums";
-import { DeepPartial } from "../../utility-types";
+import { DeepPartial } from "../../common-types";
 import { AdmissionRequest } from "../../common-types";
 
 describe("mismatchedName", () => {

diff --git a/src/lib/filter/adjudicators/postCollection.test.ts b/src/lib/filter/adjudicators/postCollection.test.ts
@@ -17,7 +17,7 @@ import { KubernetesObject } from "kubernetes-fluent-client";
 import { Binding } from "../../types";
 import { Event, Operation } from "../../enums";
 import { defaultBinding, defaultFilters } from "./defaultTestObjects";
-import { DeepPartial } from "../../utility-types";
+import { DeepPartial } from "../../common-types";
 
 describe("bindsToKind", () => {
   //[ Binding, Kind, result ]

diff --git a/src/lib/finalizer.ts b/src/lib/finalizer.ts
@@ -6,7 +6,7 @@ import Log from "./telemetry/logger";
 import { Binding } from "./types";
 import { Operation } from "./enums";
 import { PeprMutateRequest } from "./mutate-request";
-import { DeepPartial } from "./utility-types";
+import { DeepPartial } from "./common-types";
 
 export function addFinalizer<K extends KubernetesObject>(request: PeprMutateRequest<K>): void {
   // if a DELETE is being processed, don't add a finalizer

diff --git a/src/lib/mutate-request.ts b/src/lib/mutate-request.ts
@@ -5,7 +5,7 @@ import { Operation } from "./enums";
 import { KubernetesObject } from "kubernetes-fluent-client";
 import { clone, mergeDeepRight } from "ramda";
 import { AdmissionRequest } from "./common-types";
-import { DeepPartial } from "./utility-types";
+import { DeepPartial } from "./common-types";
 
 // PeprMutateRequest class for mutation request handling
 export class PeprMutateRequest<T extends KubernetesObject> {

diff --git a/src/lib/utility-types.ts b/src/lib/utility-types.ts