Skip to content

Commit

Permalink
chore(test): enforce ordering for callback processing (#1867)
Browse files Browse the repository at this point in the history
## Description
Add missing test case to definedCallback()
...

End to End Test:  <!-- if applicable -->  
(See [Pepr Excellent
Examples](https://github.com/defenseunicorns/pepr-excellent-examples))

## Related Issue

Fixes #1859

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Co-authored-by: Sam Mayer <[email protected]>
Co-authored-by: Case Wylie <[email protected]>
  • Loading branch information
3 people authored Feb 25, 2025
1 parent 00b120b commit 1f9492b
Showing 1 changed file with 35 additions and 0 deletions.
35 changes: 35 additions & 0 deletions src/lib/filter/adjudicators/bindingAdjudicators.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -662,6 +662,41 @@ describe("definedCallback", () => {
[{ isMutate: true, mutateCallback }, mutateCallback],
[{ isWatch: true, watchCallback }, watchCallback],
[{ isFinalize: true, finalizeCallback }, finalizeCallback],
[{ isFinalize: true, isValidate: true, finalizeCallback, validateCallback }, finalizeCallback], // Finalize > Validate
[{ isFinalize: true, isWatch: true, finalizeCallback, watchCallback }, finalizeCallback], // Finalize > Watch
[
{ isFinalize: true, isMutate: true, isWatch: true, finalizeCallback, mutateCallback, watchCallback },
finalizeCallback,
], // Finalize > Mutate > Watch
[{ isValidate: true, isMutate: true, validateCallback, mutateCallback }, mutateCallback], // Mutate > Validate
[{ isWatch: true, isMutate: true, watchCallback, mutateCallback }, watchCallback], // Watch > Mutate
[{ isMutate: true, isFinalize: true, mutateCallback, finalizeCallback }, finalizeCallback], // Finalize > Mutate
[
{ isMutate: true, isWatch: true, isFinalize: true, mutateCallback, watchCallback, finalizeCallback },
finalizeCallback,
], // Finalize > Watch > Mutate
[
{ isValidate: true, isMutate: true, isFinalize: true, validateCallback, mutateCallback, finalizeCallback },
finalizeCallback,
], // Finalize > Mutate > Validate
[
{ isValidate: true, isMutate: true, isWatch: true, validateCallback, mutateCallback, watchCallback },
watchCallback,
], // Watch > Mutate > Validate
[{ isValidate: true, isWatch: true, validateCallback, watchCallback }, watchCallback], // Watch > Validate
[
{
isValidate: true,
isMutate: true,
isWatch: true,
isFinalize: true,
validateCallback,
mutateCallback,
watchCallback,
finalizeCallback,
},
finalizeCallback,
], // Finalize > Watch > Mutate > Validate
])("given %j, returns %s", (given, expected) => {
const binding: Binding = {
...defaultBinding,
Expand Down

0 comments on commit 1f9492b

Please sign in to comment.