Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/asset/dcr: refactor to support non-rpc wallets #1227

Merged
merged 10 commits into from
Oct 25, 2021
Merged

client/asset/dcr: refactor to support non-rpc wallets #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f755d3d
client/asset/dcr: refactor to support non-rpc wallets
itswisdomagain Oct 2, 2021
3576ffd
add comments
itswisdomagain Oct 2, 2021
576bc38
rename Lock, Unlock to LockWallet, UnlockWallet
itswisdomagain Oct 3, 2021
f7eeaf5
refactor Wallet.Balance to Wallet.AccountBalance
itswisdomagain Oct 3, 2021
89bb9d2
joe's review and some cleanup
itswisdomagain Oct 4, 2021
89fa6ea
undo asset init changes
itswisdomagain Oct 15, 2021
717abe9
client/asset/dcr: add package-level func for setting custom wallets
itswisdomagain Oct 18, 2021
df9116e
allow Wallet impls provide tip change tracking where possible
itswisdomagain Oct 20, 2021
b01778a
buck's review
itswisdomagain Oct 25, 2021
8ad124e
chapp review
itswisdomagain Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions client/asset/dcr/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,6 @@ func loadConfig(settings map[string]string, network dex.Network) (*Config, *chai
return nil, nil, fmt.Errorf("error parsing config: %w", err)
}

missing := ""
if cfg.RPCUser == "" {
missing += " username"
}
if cfg.RPCPass == "" {
missing += " password"
}
if missing != "" {
return nil, nil, fmt.Errorf("missing dcrwallet rpc credentials:%s", missing)
}

// Get network settings. Zero value is mainnet, but unknown non-zero cfg.Net
// is an error.
var defaultServer string
Expand Down
Loading