Several particle system effects won't stop playing during replay.

[sapientN3T]

Steps to reproduce:

1. watch_replay("985")
2. observe that Tactical Blunder is played on Turn 8 (player 0 response to player 1 summon), and spell fizzles.
3. observe that many turns later, and at the end of the replay, the animation is still playing (see screenshot)

[ghost]

Ugh, this looks bad. And there are remains from a couple Translocate invocations over there, aren't they?

[ghost]

I have no idea what is happening or where to start tackling.

I suppose it is easy to use is_replay for removing them completely from replays until the bug is fixed.

citadel/data/objects/citadel_controller.cfg

Line 18 in b9ab76f

is_replay: "bool :: _replay != null",

[ghost]

I could try to log PlayCardParticles.end_anim and try to see if forcing it set to non null by overwriting the card code makes the problem disappear. But I wouldn't be surprised if the replay data is already able to force stored (past) card code over updated card code.

I think the Tactical Blunder that starts the party fizzles even it's successfully casted (I think). That'd be a first oddity.

I would also like to observe some more tactical blunders in other games, to be sure that this is a general problem in replays, not a case unique to game 985.