Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect peer dep #356

Closed
richardsimko opened this issue Sep 14, 2021 · 2 comments
Closed

Incorrect peer dep #356

richardsimko opened this issue Sep 14, 2021 · 2 comments
Assignees
@davesag @richardsimko
Labels
bug Something isn't working dependencies Pull requests that update a dependency file investigation-opened An issue has been raised that warrants investigation

Comments

@richardsimko
Copy link

If a project where this package is used also has the latest sinon installed (11.1.1) which should be OK according to the dependencies the following error appears on npm@7:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/sinon
npm ERR!   dev sinon@"11.1.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer sinon@"^10.0.0" from [email protected]
npm ERR! node_modules/sequelize-test-helpers
npm ERR!   dev sequelize-test-helpers@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!

Would it be OK to upgrade the peer dependency as well in this project since the dependency has been upgraded?
@davesag davesag added bug Something isn't working dependencies Pull requests that update a dependency file investigation-opened An issue has been raised that warrants investigation labels Sep 23, 2021
@davesag
Copy link
Owner

davesag commented Sep 23, 2021

Thank I will update and get back to you shortly. Sorry for the issue.

davesag added a commit that referenced this issue Sep 24, 2021
@davesag
#356 fixed incorrect peer dependency restriction
1564990
davesag added a commit that referenced this issue Sep 24, 2021
@davesag
Merge pull request #360 from davesag/feature/356/fix-incorrect-peer
7612dd8 
[bug fix, #356] fixed incorrect peer dependency restriction
@davesag
Copy link
Owner

davesag commented Sep 24, 2021

Thanks @richardsimko I have fixed this and released an update - Version 1.4.2

Sorry for the inconvenience.

@davesag davesag closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davesag davesag

@richardsimko richardsimko

Labels
bug Something isn't working dependencies Pull requests that update a dependency file investigation-opened An issue has been raised that warrants investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davesag @richardsimko