getOpenOrders - fix validation #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's get it up to date
Possibly when this was written the primary and secondary currencies were mandatory arguments when pulling the getOpenOrders endpoint, but they are not mandatory anymore, so I have removed this validation restriction. Also, the max size of a page is now 100. See here for confirmation: https://www.independentreserve.com/au/features/api#GetOpenOrders
Fix tests now that primary and secondary currencies are not mandatory parameters, and max page size is 100
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #803 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 577 577
=========================================
Hits 577 577 ☔ View full report in Codecov by Sentry. |
davesag
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the validation requirement that primary and secondary currencies are required in the arguments for this endpoint, and increased the page size max to 100.
See here:
https://www.independentreserve.com/au/features/api#GetOpenOrders