Skip to content

Commit

Permalink
Merge pull request #346 from ev-br/spec_cases_rm_cumprod
Browse files Browse the repository at this point in the history
MAINT: always skip test_nan_propagation[cumulative_prod]
  • Loading branch information
ev-br authored Mar 3, 2025
2 parents 2ffb924 + 2f8c1c0 commit 28f1dbf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 1 addition & 4 deletions array-api-strict-skips.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ array_api_tests/test_special_cases.py::test_iop[__ipow__(x1_i is -0 and x2_i > 0
# (https://github.com/data-apis/array-api-tests/issues/168)
array_api_tests/test_statistical_functions.py::test_sum

# 2024.12 new failures, investigate
# Stubs have a comment: (**note**: libraries may return ``NaN`` to match Python behavior.); Apparently, all libraries do just that
array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is +infinity and isfinite(x2_i) and x2_i > 0) -> +infinity]
array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is +infinity and isfinite(x2_i) and x2_i < 0) -> -infinity]
array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is -infinity and isfinite(x2_i) and x2_i > 0) -> -infinity]
Expand All @@ -27,6 +27,3 @@ array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(x1_i is -infinity
array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(isfinite(x1_i) and x1_i > 0 and x2_i is -infinity) -> -0]
array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(isfinite(x1_i) and x1_i < 0 and x2_i is +infinity) -> -0]

# 2024.12 new failure, ndim=0 not allowed in cumulative_prod
array_api_tests/test_special_cases.py::test_nan_propagation[cumulative_prod]

2 changes: 1 addition & 1 deletion array_api_tests/test_special_cases.py
Original file line number Diff line number Diff line change
Expand Up @@ -1332,7 +1332,7 @@ def test_empty_arrays(func_name, expected): # TODO: parse docstrings to get exp

@pytest.mark.parametrize(
"func_name", [f.__name__ for f in category_to_funcs["statistical"]
if f.__name__ != 'cumulative_sum']
if f.__name__ not in ['cumulative_sum', 'cumulative_prod']]
)
@given(
x=hh.arrays(dtype=hh.real_floating_dtypes, shape=hh.shapes(min_side=1)),
Expand Down

0 comments on commit 28f1dbf

Please sign in to comment.