refactor(coinjoin): refactor Wallet #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
force-pushed
the
feature-coinjoin-refactor
branch
from
64dac26 to
6180554
Compare
HashEngineering
changed the title
* remove from Wallet
* support empty wallet on unmixed or mixed funds only
Codecov ReportBase: 46.44% // Head: 46.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature-coinjoin #191 +/- ##
======================================================
+ Coverage 46.44% 46.47% +0.02%
- Complexity 6002 6093 +91
======================================================
Files 416 423 +7
Lines 44643 45181 +538
Branches 6249 6294 +45
======================================================
+ Hits 20734 20997 +263
- Misses 21588 21856 +268
- Partials 2321 2328 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
HashEngineering
commented
Feb 2, 2023
Comment on lines
+516
to
+521
| message CoinJoin { | ||
| // key chain | ||
| repeated Key key = 1; | ||
| // last value of rounds from mixing | ||
| required int32 rounds = 2; | ||
| } |
There was a problem hiding this comment.
rounds is used to calculate the balance of coinjoin coins.
if all coins were mixed for 4 rounds, but the rounds = 5 then the coinjoin balance will be zero. This value needs to persist.
HashEngineering
commented
Feb 2, 2023
Comment on lines
+47
to
+48
| public class WalletEx extends Wallet { | ||
| private static final Logger log = LoggerFactory.getLogger(WalletEx.class); |
There was a problem hiding this comment.
WalletEx is a temporary name.
HashEngineering
commented
Feb 2, 2023
Comment on lines
+20501
to
+20506
| public interface CoinJoinOrBuilder extends | ||
| // @@protoc_insertion_point(interface_extends:wallet.CoinJoin) | ||
| com.google.protobuf.MessageLiteOrBuilder { | ||
|
|
||
| /** | ||
| * <pre> |
There was a problem hiding this comment.
I wonder why the bitcoinj developers like this autogenerated file to be committed into the repo.
HashEngineering
commented
Feb 2, 2023
| @@ -93,7 +93,7 @@ public void setUp(BlockStore blockStore) throws Exception { | |||
| // Reduce the number of keys we need to work with to speed up these tests. | |||
| KeyChainGroup kcg = KeyChainGroup.builder(UNITTEST).lookaheadSize(4).lookaheadThreshold(2). | |||
| fromRandom(Script.ScriptType.P2PKH).build(); | |||
| wallet = new Wallet(UNITTEST, kcg); | |||
| wallet = createWallet(kcg); | |||
There was a problem hiding this comment.
We need to allow derived classes to create their own wallet objects.
HashEngineering
force-pushed
the
feature-coinjoin-refactor
branch
from
8b88297 to
2583b05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
CoinJoinExtensionHow Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only