Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: can't load BLS wasm module in Chrome #168

Merged
merged 6 commits into from
Jul 27, 2020
Merged

fix!: can't load BLS wasm module in Chrome #168

merged 6 commits into from
Jul 27, 2020

Conversation

shuplenkov
Copy link
Collaborator

@shuplenkov shuplenkov commented Jul 24, 2020 •
edited by shumkov
Loading

Issue being fixed or feature implemented

Can't load BLS wasm module in Chrome since it's bigger than 4 Kb

What was done?

  • Updated bls-signaures library
  • Changed QuorumEntry#verify, QuorumEntry#isValidQuorumSig and QuorumEntry#isValidMemberSig methods

Breaking Changes

QuorumEntry#verify, QuorumEntry#isValidQuorumSig and QuorumEntry#isValidMemberSig methods now return promise

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

antouhou
antouhou approved these changes Jul 24, 2020
View reviewed changes
Copy link
Collaborator

@antouhou antouhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@shumkov shumkov changed the title feat!: use asynchronous bls library load feat!: use asynchronous BLS library load Jul 24, 2020
shumkov
shumkov requested changes Jul 24, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment above

@shumkov shumkov requested a review from Cofresi July 24, 2020 15:53
Cofresi
Cofresi approved these changes Jul 26, 2020
View reviewed changes
Copy link

@Cofresi Cofresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Cofresi
Cofresi suggested changes Jul 26, 2020
View reviewed changes
shumkov
shumkov reviewed Jul 27, 2020
View reviewed changes
@shumkov shumkov changed the title feat!: use asynchronous BLS library load feat!: asynchronously load BLS library Jul 27, 2020
@shuplenkov shuplenkov changed the title feat!: asynchronously load BLS library fix!: can't load BLS wasm module in Chrome Jul 27, 2020
shumkov
shumkov approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@shumkov shumkov requested a review from Cofresi July 27, 2020 12:38
Cofresi
Cofresi approved these changes Jul 27, 2020
View reviewed changes
Copy link

@Cofresi Cofresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@shuplenkov shuplenkov merged commit d12e1f0 into v0.19-dev Jul 27, 2020
@shuplenkov shuplenkov deleted the async-bls branch July 27, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou antouhou approved these changes

@Cofresi Cofresi Cofresi approved these changes

@jawid-h jawid-h Awaiting requested review from jawid-h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuplenkov @shumkov @antouhou @Cofresi