Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce quorum verification in SML #167

Merged
merged 52 commits into from
Jul 13, 2020
Merged

Conversation

Cofresi
Copy link

@Cofresi Cofresi commented Jul 6, 2020

Issue being fixed or feature implemented

Basic quorum processing has already been added to 0.18. But there is no way to verify the quorums without BLS signatures. This PR adds this verification and some helper functions for the client that consumes the SMList

What was done?

Added functions for quorum verification using bls signatures

How Has This Been Tested?

node test, browser tests, but only with Firefox. Chrome will have to wait until we can load the bls-signatures lib asynchronously

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@Cofresi Cofresi changed the title Quorum verification feat: Quorum verification Jul 6, 2020
@Cofresi Cofresi requested review from antouhou and shumkov July 7, 2020 00:49
@shumkov shumkov changed the title feat: Quorum verification feat: quorum verification in SML Jul 10, 2020
@shumkov shumkov changed the title feat: quorum verification in SML feat: introduce quorum verification in SML Jul 10, 2020
* @return {Object[]} scores
*/
SimplifiedMNList.prototype.calculateScores = function calculateScores(modifier) {

Copy link
Member

@shumkov shumkov Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an extra line

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@Cofresi Cofresi merged commit ded3a31 into v0.19-dev Jul 13, 2020
@Cofresi Cofresi deleted the quorum-verification branch October 1, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants