forked from bitpay/bitcore-lib
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce quorum verification in SML #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication # Conflicts: # lib/deterministicmnlist/SimplifiedMNList.js # package-lock.json # package.json
…fication # Conflicts: # lib/deterministicmnlist/SimplifiedMNListDiff.js # package-lock.json # package.json
shumkov
reviewed
Jul 10, 2020
shumkov
reviewed
Jul 10, 2020
shumkov
reviewed
Jul 10, 2020
shumkov
reviewed
Jul 10, 2020
shumkov
reviewed
Jul 10, 2020
shumkov
reviewed
Jul 13, 2020
* @return {Object[]} scores | ||
*/ | ||
SimplifiedMNList.prototype.calculateScores = function calculateScores(modifier) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an extra line
shumkov
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Basic quorum processing has already been added to 0.18. But there is no way to verify the quorums without BLS signatures. This PR adds this verification and some helper functions for the client that consumes the SMList
What was done?
Added functions for quorum verification using bls signatures
How Has This Been Tested?
node test, browser tests, but only with Firefox. Chrome will have to wait until we can load the bls-signatures lib asynchronously
Breaking Changes
Checklist: