Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json to support illuminate config 12 #621

Closed
wants to merge 1 commit into from

Conversation

taha-moghaddam
Copy link

Thank you for helping to make this package better!

Please make sure you've read CONTRIBUTING.md
before submitting your pull request, and that you have:

  • provided a rationale for your change (I try not to add features that are going to have a limited user-base)
  • checked your coding style with composer run style:check
  • analyzed your code with composer run analyze
  • added tests
  • confirm all old and new tests pass with composer run tests
  • documented any change in behaviour (e.g. updated the README.md, etc.)
  • only submitted one pull request per feature

Thank you!

@cviebrock
Copy link
Owner

Thanks for the PR @taha-moghaddam , but there are some other pieces that need to be in place before I can support Laravel 12. Specifically, https://github.com/larastan/larastan needs to have a version that works with L12.

Also, all the illuminate/* packages should be updated, not just illuminate/config. And finally, I would like to see what the PHP requirements are for L12 as well (i.e. will it work on 8.2, or does it require 8.3 or 8.4 even).

Once all of those things are in place (and it might be after L12 is officially launched), I will update this package.

@cviebrock cviebrock closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants