Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows #22

Merged
merged 41 commits into from
Oct 4, 2023
Merged

Add windows #22

merged 41 commits into from
Oct 4, 2023

Conversation

robertodr
Copy link
Contributor

@robertodr robertodr commented May 26, 2023 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@robertodr robertodr requested a review from maxscheurer as a code owner May 26, 2023 08:33
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits May 26, 2023 08:35
@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

@robertodr
Copy link
Contributor Author

robertodr commented May 26, 2023 •
edited
Loading 

CMake Error:
  Running

   'D:/bld/cppe_1685090692676/_build_env/Library/bin/ninja.exe' '-C' 'D:/bld/cppe_1685090692676/work/build/cppe-core-prefix/src/cppe-core-build' '-t' 'recompact'

  failed with:

   ninja: error: build.ninja:489: multiple rules generate cppe.lib

@maxscheurer
Copy link
Contributor

maxscheurer commented May 26, 2023 •
edited
Loading

The error maybe needs a patch in cppe itself? I/We could try to hook up conda-based Windows CI there? nvm just saw the patch files you added...

@robertodr
Copy link
Contributor Author

the next thing I am going to try is to rewrite the CMake scripts to remove the super-build with ExternalProject... Google and the CMake issue board seems to suggest that this is a bug with ninja, but the ExternalProject stuff it's rather unnecessary for such a small project IMO.

@maxscheurer
Copy link
Contributor

Ah you mean the cppe-internal super-build? I guess I did this because of Psi4, but if you succeed to remove it, I'm fine with it, great 👍

@robertodr
Copy link
Contributor Author

It's relatively straightforward. I have some time next week to look at it

@loriab
Copy link
Contributor

loriab commented May 26, 2023

Hi Roberto and Max! This is a coincidence -- I was just bringing up trying to adapt this for Windows. :-)

  • I second removing the superbuild. I did it for libefp/pylibefp, too, years ago, but I mean to get rid of it now. It makes sense for psi, but not for smaller projects, imo.
  • I've been doing cmake overhauls in combination with Windows builds a lot this spring, and I've converged on a checklist that could be handy: cmake 2023 updates psi4/gdma#6
  • The biggest thing to making Win work (if starting from a point like my c.2016 cmake) is often that the install(targets needs to be expanded to include runtime destintion (for the dll) and the projectConfig.cmake needs an overhaul to be target based. Also, -DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON and /EHsc added to CXX_FLAGS. A few resources in case helpful: ambit (CMake 2023 updates & conda-forge mods jturney/ambit#58) & gdma(https://github.com/psi4/gdma/commits/v2.3.3 "add CMake buildsystem for L, M, W platforms" and "add exports to Python Module")
  • I'm glad to help, do, or consult -- whatever's useful

@robertodr robertodr mentioned this pull request May 29, 2023
Merged
5 tasks
@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cppe-feedstock/actions/runs/5212619131.

@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cppe-feedstock/actions/runs/5212645614.

@maxscheurer
Copy link
Contributor

@conda-forge-admin, please rerender

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cppe-feedstock/actions/runs/5220511205.

@maxscheurer
Copy link
Contributor

@conda-forge-admin, please restart ci

@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cppe-feedstock/actions/runs/5319099002.

@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cppe-feedstock/actions/runs/5473371099.

@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

@robertodr
Copy link
Contributor Author

@maxscheurer this builds on all supported platforms off of official master branch. I would suggest that you cut a new release and we merge this (just so it doesn't bit-rot into uselessness) even though the current version of master cannot build and upload wheels to PyPI.

@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

@robertodr robertodr mentioned this pull request Sep 26, 2023
Closed
@robertodr
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits October 4, 2023 13:25
@robertodr robertodr merged commit 0b14847 into conda-forge:main Oct 4, 2023
@robertodr robertodr deleted the windowsss-tribulationsss branch October 4, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxscheurer maxscheurer Awaiting requested review from maxscheurer maxscheurer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertodr @maxscheurer @loriab