Add the organization name and url/homepage members to PomSettings
#4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PomSettings.organizationmember corresponds to a Maven group. The organization name and url properties are available in Maven, Gradle, and sbt. Shall we add them inPomSettingsfor Mill too?I haven't added the
organizationUrl/organizationHomepagemember yet as I am not sure whether we stick to the former name (more similar to Maven and Gradle's) or the latter (consistent with sbt). I have added a backward-comaptible companion objectapplymethod for the code to work with minimal modification and haven't updated the callers or the conversion buildgen code yet.