Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for super task resolution in Mill #4646

Closed
wants to merge 2 commits into from

Conversation

zelosleone
Copy link
Contributor

Implement enhanced task resolution for super tasks, allowing:

  • Direct super task resolution
  • Qualified super task resolution across module hierarchies
  • Preserving original selector for qualified super tasks

Changes include:

  • Modifying Resolve to handle super task selectors
  • Updating ResolveCore to support super task resolution
  • Adding comprehensive test cases for super task resolution in different module hierarchies

I had to make a new PR due to conflicts, and its actually more easy to do this instead of dealing with 7 commits from main so sorry about that @lihaoyi

I wanted to go with your suggestion of using segments as that would be more clear, also included more complex tests to try to reproduce the issue you showed with manual testing.

Fixes #4119

Implement enhanced task resolution for super tasks, allowing:
- Direct super task resolution
- Qualified super task resolution across module hierarchies
- Preserving original selector for qualified super tasks

Changes include:
- Modifying `Resolve` to handle super task selectors
- Updating `ResolveCore` to support super task resolution
- Adding comprehensive test cases for super task resolution in different module hierarchies
@lefou
Copy link
Member

lefou commented Mar 4, 2025

I had to make a new PR due to conflicts, and its actually more easy to do this instead of dealing with 7 commits from main so sorry about that @lihaoyi

FYI, you can just git --force-with-lease push you reworked or new branch over the existing pull request branch. This would be the preferred way, once review has started and essential details where discussed.

@zelosleone
Copy link
Contributor Author

I had to make a new PR due to conflicts, and its actually more easy to do this instead of dealing with 7 commits from main so sorry about that @lihaoyi

FYI, you can just git --force-with-lease push you reworked or new branch over the existing pull request branch. This would be the preferred way, once review has started and essential details where discussed.

Oh, thank you! I suck at git tbh, since i mainly worked in my personal projects before i didn't had to deal with all the formality, sorry about this, will do that next time and will take that into my notes.

@zelosleone
Copy link
Contributor Author

@lihaoyi @lefou huh, should i close this one and try to solve the other pr with git?

@lihaoyi
Copy link
Member

lihaoyi commented Mar 5, 2025

@zelosleone please use the PRs you already have and stop opening new ones unnecessarily

@zelosleone zelosleone closed this Mar 5, 2025
@zelosleone zelosleone deleted the supertaskster branch March 5, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow invocation of foo.super tasks from the command line (500USD Bounty)
3 participants