Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable sort for sorting coins #235

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

lyricnz
Copy link
Collaborator

@lyricnz lyricnz commented Oct 17, 2021

This should help #231. We might need to explicitly pre-sort (say by Rank), or make the comparison functions consider more than one attribute.

@lyricnz lyricnz linked an issue Oct 17, 2021 that may be closed by this pull request
Copy link
Member

@miguelmota miguelmota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍
Pre-sorting by rank would also be good

@lyricnz lyricnz merged commit 30fa30c into cointop-sh:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort is not stable when values are identical
2 participants