Only execute CrossfadeTransition if view is shown. #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
changed the title
nuhkoca
reviewed
Sep 27, 2021
Co-authored-by: Nuh Koca <[email protected]>
colinrtwhite
force-pushed
the
colin/crossfade_shown
branch
from
a06f2da to
a83b36b
Compare
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Only execute CrossfadeTransition if view isShown. * Apply suggestions from code review Co-authored-by: Nuh Koca <[email protected]> * Fix tests. Co-authored-by: Nuh Koca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #889