Enable the JVM IR backend. #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
commented
Feb 14, 2021
| @@ -660,7 +676,7 @@ public final class coil/size/OriginalSize : coil/size/Size { | |||
| public fun writeToParcel (Landroid/os/Parcel;I)V | |||
| } | |||
|
|
|||
| public class coil/size/OriginalSize$Creator : android/os/Parcelable$Creator { | |||
| public final class coil/size/OriginalSize$Creator : android/os/Parcelable$Creator { | |||
There was a problem hiding this comment.
Interestingly this is not a binary incompatible change, however classes that extend this class with throw a VerifyError when instantiated. Assuming the Kotlin team has taken this into account.
Closed
colinrtwhite
force-pushed
the
colin/ir
branch
from
35c9491 to
98af499
Compare
colinrtwhite
commented
Mar 3, 2021
| @@ -4,6 +4,7 @@ public abstract class coil/fetch/VideoFrameFetcher : coil/fetch/Fetcher { | |||
| public static final field VIDEO_FRAME_OPTION_KEY Ljava/lang/String; | |||
| public fun <init> (Landroid/content/Context;)V | |||
| public fun fetch (Lcoil/bitmap/BitmapPool;Ljava/lang/Object;Lcoil/size/Size;Lcoil/decode/Options;Lkotlin/coroutines/Continuation;)Ljava/lang/Object; | |||
| public static final synthetic fun fetch$suspendImpl (Lcoil/fetch/VideoFrameFetcher;Lcoil/bitmap/BitmapPool;Ljava/lang/Object;Lcoil/size/Size;Lcoil/decode/Options;Lkotlin/coroutines/Continuation;)Ljava/lang/Object; | |||
There was a problem hiding this comment.
It's a bug in 1.4.31 that this is declared public, but it can't be called by Java and it's a Kotlin implementation detail so I wouldn't consider it part of the public API.
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Enable the JVM IR backend. * Update API. * Work around bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://blog.jetbrains.com/kotlin/2021/02/the-jvm-backend-is-in-beta-let-s-make-it-stable-together/
Blocked by: https://youtrack.jetbrains.com/issue/KT-44993 (or a similarWorked around the issue by removinginlinebug). This bug is fixed in Kotlin1.5.0.internalfor the function that was causing the issue.