Prevent completions when in JSX nodes

[krismuniz]

Hi there 👋

This contribution adds "JSXText", "JSXAttributeValue", "JSXOpenTag", "JSXCloseTag", "JSXSelfClosingTag" to dontComplete to ensure that we do not show JavaScript completions when in a JSX node.

Minimal Repro - Try Codemirror

Examples

export function MyComponent () {
  return <p>func|
/*              ^ cursor
 * I'm inside of a JSXText node, but it would
 * show `function` as a completion, which is
 * not very useful inside of a `JSXText`
 */

export function MyComponent () {
  return <p className="func|
/*                         ^ cursor
 * I'm inside of a JSXAttributeValue node,
 * but it would show `function` as a
 * completion, which is not very useful
 * inside of a `JSXAttributeValue`
 */

Screenshots - Before

Screenshots - After

CleanShot.2024-11-23.at.10.36.58.mp4

[marijnh]

Thanks, that looks like a good idea.