Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address lint issues #349

Merged
merged 7 commits into from
Oct 26, 2022
Merged

chore: address lint issues #349

merged 7 commits into from
Oct 26, 2022

Conversation

Apollon77
Copy link
Collaborator

No description provided.

@Apollon77 Apollon77 requested a review from JKRhb October 18, 2022 07:19
@coveralls
Copy link

coveralls commented Oct 18, 2022

Pull Request Test Coverage Report for Build 3271356898

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 91.739%

Files with Coverage Reduction New Missed Lines %
lib/server.ts 4 86.51%
Totals Coverage Status
Change from base Build 3271281568: 0.06%
Covered Lines: 2842
Relevant Lines: 3055

💛 - Coveralls

@Apollon77
Copy link
Collaborator Author

@JKRhb PR ready for review

@JKRhb
Copy link
Member

JKRhb commented Oct 18, 2022

@JKRhb PR ready for review

Awesome,thank you!

Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Apollon77 Apollon77 merged commit 131db1a into master Oct 26, 2022
@JKRhb JKRhb deleted the lint1 branch October 26, 2022 17:07
@JKRhb JKRhb restored the lint1 branch October 26, 2022 17:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3271541141

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 91.739%

Totals Coverage Status
Change from base Build 3271281568: 0.06%
Covered Lines: 2842
Relevant Lines: 3055

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 8, 2024

Pull Request Test Coverage Report for Build 3271437025

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 91.739%

Files with Coverage Reduction New Missed Lines %
lib/server.ts 4 86.51%
Totals Coverage Status
Change from base Build 3271281568: 0.06%
Covered Lines: 2842
Relevant Lines: 3055

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants