Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 404.html #596

Closed
wants to merge 1 commit into from
Closed

update 404.html #596

wants to merge 1 commit into from

Conversation

AbhiGiri
Copy link

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@@ -40,12 +38,16 @@ <h3 class="message">Oops! That was unexpected...</h3>
</div>
<div class="footer-small-title center"> <span class="blue-grey-text text-lighten-3 uppercase"> Licensed under {{ site.license }}</span> </div>
</footer>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpa0morplm/404.html
+++ b/tmp/tmpa0morplm/404.html
@@ -38,7 +38,7 @@
     </div>
     <div class="footer-small-title center"> <span class="blue-grey-text text-lighten-3 uppercase"> Licensed under {{ site.license }}</span> </div>
   </footer>
-  
+
   <script>
     window.onload = (e) => {
       document.querySelectorAll(".hidden-until-ready").forEach(el => {

<script>
window.onload = (e) => {
document.querySelectorAll(".hidden-until-ready").forEach(el => {
el.classList.remove('hidden-until-ready');
});
};
</script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpa0morplm/404.html
+++ b/tmp/tmpa0morplm/404.html
@@ -46,7 +46,7 @@
       });
     };
   </script>
-  
+
   <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.0/jquery.min.js"></script>
   <script src="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.8/js/materialize.min.js"></script>
 </body>

@@ -40,12 +38,16 @@ <h3 class="message">Oops! That was unexpected...</h3>
</div>
<div class="footer-small-title center"> <span class="blue-grey-text text-lighten-3 uppercase"> Licensed under {{ site.license }}</span> </div>
</footer>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.

Origin: HTMLLintBear, Section: html.

<script>
window.onload = (e) => {
document.querySelectorAll(".hidden-until-ready").forEach(el => {
el.classList.remove('hidden-until-ready');
});
};
</script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.

Origin: HTMLLintBear, Section: html.

@TravisBuddy
Copy link

Travis tests have failed

Hey @AbhiGiri,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.3.3

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci
Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/404.html
|    |++++| /app/404.html
|  38|  38|     </div>
|  39|  39|     <div class="footer-small-title center"> <span class="blue-grey-text text-lighten-3 uppercase"> Licensed under {{ site.license }}</span> </div>
|  40|  40|   </footer>
|  41|    |-  
|    |  41|+
|  42|  42|   <script>
|  43|  43|     window.onload = (e) => {
|  44|  44|       document.querySelectorAll(".hidden-until-ready").forEach(el => {
[INFO][11:23:22] Applied 'ShowPatchAction' on '404.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/404.html
|    |++++| /app/404.html
|  46|  46|       });
|  47|  47|     };
|  48|  48|   </script>
|  49|    |-  
|    |  49|+
|  50|  50|   <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.0/jquery.min.js"></script>
|  51|  51|   <script src="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.8/js/materialize.min.js"></script>
|  52|  52| </body>
[INFO][11:23:22] Applied 'ShowPatchAction' on '404.html' from 'SpaceConsistencyBear'.
Executing section html...
[WARNING][11:23:22] HTMLLintBear: This result has no patch attached.
[WARNING][11:23:22] HTMLLintBear: This result has no patch attached.

404.html
|  41| ··
|    | [MAJOR] HTMLLintBear:
|    | Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the '  ' at the end of the line.

404.html
|  49| ··
|    | [MAJOR] HTMLLintBear:
|    | Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the '  ' at the end of the line.
Executing section yml...
Executing section cli...

@KVGarg
Copy link
Contributor

KVGarg commented Mar 13, 2019

Hi @AbhiGiri Is this PR has an associated issue? If not, then a request to not to create PR unnecessarily 🙂

@jayvdb
Copy link
Member

jayvdb commented Aug 25, 2019

Contributor deleted their repository, so this PR can not be salvaged

@jayvdb jayvdb closed this Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants