-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update 404.html #596
update 404.html #596
Conversation
@@ -40,12 +38,16 @@ <h3 class="message">Oops! That was unexpected...</h3> | |||
</div> | |||
<div class="footer-small-title center"> <span class="blue-grey-text text-lighten-3 uppercase"> Licensed under {{ site.license }}</span> </div> | |||
</footer> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
Origin: SpaceConsistencyBear, Section: spacing
.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpa0morplm/404.html
+++ b/tmp/tmpa0morplm/404.html
@@ -38,7 +38,7 @@
</div>
<div class="footer-small-title center"> <span class="blue-grey-text text-lighten-3 uppercase"> Licensed under {{ site.license }}</span> </div>
</footer>
-
+
<script>
window.onload = (e) => {
document.querySelectorAll(".hidden-until-ready").forEach(el => {
<script> | ||
window.onload = (e) => { | ||
document.querySelectorAll(".hidden-until-ready").forEach(el => { | ||
el.classList.remove('hidden-until-ready'); | ||
}); | ||
}; | ||
</script> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
Origin: SpaceConsistencyBear, Section: spacing
.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpa0morplm/404.html
+++ b/tmp/tmpa0morplm/404.html
@@ -46,7 +46,7 @@
});
};
</script>
-
+
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.0/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.8/js/materialize.min.js"></script>
</body>
@@ -40,12 +38,16 @@ <h3 class="message">Oops! That was unexpected...</h3> | |||
</div> | |||
<div class="footer-small-title center"> <span class="blue-grey-text text-lighten-3 uppercase"> Licensed under {{ site.license }}</span> </div> | |||
</footer> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.
Origin: HTMLLintBear, Section: html
.
<script> | ||
window.onload = (e) => { | ||
document.querySelectorAll(".hidden-until-ready").forEach(el => { | ||
el.classList.remove('hidden-until-ready'); | ||
}); | ||
}; | ||
</script> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.
Origin: HTMLLintBear, Section: html
.
Travis tests have failedHey @AbhiGiri, Ruby: 2.3.3docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci
|
Hi @AbhiGiri Is this PR has an associated issue? If not, then a request to not to create PR unnecessarily 🙂 |
Contributor deleted their repository, so this PR can not be salvaged |
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>
to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!