Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(volo-cli): remove async-trait in templates #332

Merged
merged 1 commit into from
Jan 21, 2024
Merged

chore(volo-cli): remove async-trait in templates #332

merged 1 commit into from
Jan 21, 2024

Conversation

hohowt
Copy link
Contributor

@hohowt hohowt commented Jan 21, 2024

Motivation

Solution

@hohowt hohowt requested review from a team as code owners January 21, 2024 04:17
@CLAassistant
Copy link

CLAassistant commented Jan 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

PureWhiteWu
PureWhiteWu approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@PureWhiteWu PureWhiteWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yukiiiteru yukiiiteru changed the title remove async-trait dependencies chore(volo-cli): remove async-trait in templates Jan 21, 2024
@yukiiiteru yukiiiteru merged commit 1627183 into cloudwego:main Jan 21, 2024
16 checks passed
@hohowt hohowt mentioned this pull request Jan 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureWhiteWu PureWhiteWu PureWhiteWu approved these changes

@yukiiiteru yukiiiteru yukiiiteru approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hohowt @CLAassistant @PureWhiteWu @yukiiiteru