Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unfair lock behavior in copied stream #71

Merged
merged 3 commits into from
Feb 20, 2025
Merged

fix: unfair lock behavior in copied stream #71

merged 3 commits into from
Feb 20, 2025

Conversation

N3kox
Copy link
Contributor

@N3kox N3kox commented Feb 19, 2025

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

修复复制后的 stream 锁粒度过大导致的性能问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@N3kox N3kox requested review from meguminnnnnnnnn, hi-pender and shentongmartin and removed request for meguminnnnnnnnn February 19, 2025 03:30
@hi-pender
Copy link
Contributor

CI 中有失败的 case,看下哈

Copy link

github-actions bot commented Feb 19, 2025

📊 Coverage Report:

File coverage threshold (20%) satisfied:	PASS
Package coverage threshold (30%) satisfied:	PASS
Total coverage threshold (83%) satisfied:	PASS
Total test coverage: 83.4% (3235/3881)

@N3kox
Copy link
Contributor Author

N3kox commented Feb 19, 2025

CI 中有失败的 case,看下哈

rerun 好了,不是本次改动中的 test 问题,之后我看看修下。

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2025

CLA assistant check
All committers have signed the CLA.

This comment was marked as resolved.

Copy link
Contributor

@hi-pender hi-pender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@N3kox N3kox merged commit 5e5dc1f into main Feb 20, 2025
13 checks passed
@N3kox N3kox deleted the fix/stream_copy branch February 20, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants