Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/readme #51

Merged
merged 7 commits into from
Jan 26, 2025
Merged

Fix/readme #51

merged 7 commits into from
Jan 26, 2025

Conversation

shentongmartin
Copy link
Contributor

What type of PR is this?

  1. fix readme's graph introduction section, replace with a tool call graph.
  2. clean up react agent code. Avoid modify config in place.
  3. clean up host multi agent code. Avoid modify config in place.

@github-actions GitHub Actions
Copy link

⚠️ Breaking API Changes Detected

This pull request contains breaking API changes that may affect compatibility:

uncompatible api changes found: 
github.com/cloudwego/eino/components/model
  Incompatible changes:
  - Options.ToolChoice: removed
  - Options.Tools: removed
  - WithToolChoice: removed
  - WithTools: removed

github.com/cloudwego/eino/schema
  Incompatible changes:
  - ToolChoice: removed
  - ToolChoiceAllowed: removed
  - ToolChoiceForbidden: removed
  - ToolChoiceForced: removed

Required Actions:

  1. Please review these changes carefully
  2. Update the user documentation to reflect these API changes
  3. Add a note in the changelog about these breaking changes

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

📊 Coverage Report:

File coverage threshold (20%) satisfied:	PASS
Package coverage threshold (30%) satisfied:	PASS
Total coverage threshold (75%) satisfied:	PASS
Total test coverage: 84.1% (3275/3892)

@shentongmartin
fix: replace graph example in readme with tool call graph
209cb3a 
Change-Id: I076c3d9fb713441b81d4c97bf67c85d95eb4cf9c
@shentongmartin
refactor: clean up react agent
1ca9471
@shentongmartin
refactor: do not modify host multi-agent's config in place
e3f9ad0 
Change-Id: I1e72db08b64f9d77c7228036e6578d987ba6972a
@shentongmartin
refactor: remove package or type alias in react agent
0f7287c 
Change-Id: I0dc1f6d815ccaac8b65f5c0c23acbc1db250e11e
@shentongmartin
fix: devops repo url
63fc942 
Change-Id: I7b6238f7c4861e0f04331de4bd78be82cce029f0
@shentongmartin
fix: replace react agent image in readme
b4dff5f 
Change-Id: I0bb814b5adfcd84de5ea9af2a1f0adfb20660929
hi-pender
hi-pender approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@hi-pender hi-pender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hi-pender hi-pender merged commit 8f485a1 into main Jan 26, 2025
10 checks passed
@hi-pender hi-pender deleted the fix/readme branch January 26, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meguminnnnnnnnn meguminnnnnnnnn meguminnnnnnnnn left review comments

@hi-pender hi-pender hi-pender approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shentongmartin @meguminnnnnnnnn @hi-pender