feat(options): add flag for GoBGP grpc port #1820
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbrtbnfgl / @mrueg / @twz123 - This one is hopefully a simple one to review |
rbrtbnfgl
approved these changes
Mar 3, 2025
mrueg
reviewed
Mar 3, 2025
| @@ -164,6 +166,8 @@ func (s *KubeRouterConfig) AddFlags(fs *pflag.FlagSet) { | |||
| "Excluded CIDRs are used to exclude IPVS rules from deletion.") | |||
| fs.BoolVar(&s.GlobalHairpinMode, "hairpin-mode", false, | |||
| "Add iptables rules for every Service Endpoint to support hairpin traffic.") | |||
| fs.Uint16Var(&s.GoBGPAdminPort, "gobgp-admin-port", defaultGoBGPAdminPort, | |||
| "Port to connect to GoBGP for administrative purposes.") | |||
There was a problem hiding this comment.
Worth mentioning that 0 = disabling it?
mrueg
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the option
--gobgp-admin-portwhich allows for setting the port that will be used for exposing GoBGP's grpc port.Fixes: #1816