Fixes HTTP1 client reads to properly timeout #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: All tests pass, when running after fixing broken GitHub Actions (see #538 ) |
This was referenced Feb 27, 2025
|
To reproduce this issue (for HTTP), do a |
The initial read(s) for reading in the HTTP request headers from the client did not make use of the `read_timeout`, and a client could cause a connection to hang forever. Also, there was no way to set the `read_timeout` for an `HttpSession` prior to this initial read, despite there being a `set_read_timeout`, so this commit also sets a "sensible default" of 60 seconds, which matches NGINX's default value for `client_header_timeout` and `client_body_timeout`.
matthewbjones
force-pushed
the
fix/http1-read-timeouts
branch
from
cac696b to
0d48675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial read(s) for reading in the HTTP request headers from the client did not make use of the
read_timeout, and a client could cause a connection to hang forever. This could allow to resource exhaustion attacks, as malicious actors could use up all available socket connections, or memory (since a buffer is allocated for each request)Also, there was no way to set the
read_timeoutfor anHttpSessionprior to this initial read, despite there being aset_read_timeout, so this commit also sets a "sensible default" of 60 seconds, which matches NGINX's default value forclient_header_timeoutandclient_body_timeout.See discussion at #447