Change the test that verify the query AST to use EXPLAIN instead
#2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
added
release-any
mamcx
force-pushed
the
mamcx/planner-printer
branch
6 times, most recently
from
419de9e to
3681c2c
Compare
* Improve output of plan * Fix print of alias and the output of joins * Allow the test utils of the plan to be used elsewhere * Use the arrow only for nodes, make timing optional * Apply new clippy hints and remove old test logic
mamcx
force-pushed
the
mamcx/query-test-explain
branch
from
46082fa to
d3d1b05
Compare
mamcx
force-pushed
the
mamcx/planner-printer
branch
from
45e5e10 to
8ede66f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Stacked on top of #2075.
This removes the manual
matchesagainst theASTto use the newEXPLAINsupport, to simplify the tests and make them easier to understand.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
In concrete, we need support for multi-column indexes, index scans for ranges