-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar appearing in file explorer on file rename #263
Comments
Thanks @Philmar1986
I'm not sure what you mean by this. Is the toolbar appearing in the file explorer sidebar? (I'm not sure if that's what your screenshot is showing on the left side.) Can you provide a larger screenshot? As for the error you pasted:
I'm not clear on where the error is occurring. It looks to me like when you open settings? |
Yes, it displaces on the in the file explorer sidebar (left side of the screenshot is file explorer sidebar). I switched off all custom css. It is not always happened. When it errors, restarting Obsidian makes it okay. Maybe it errors because I add many commands from other plugins. |
@Philmar1986 OK, I can reproduce the toolbar issue now. Thank you for narrowing down those steps! |
my pleasure |
@Philmar1986 I think I've fixed the issue in 1.20.4. Can you please try it in your usual vault, when you get a chance, and let me know how it goes? And if you see that error message again? |
I tried in my usual vault and sandbox with new version of note toolbar, this issue still errors when rename a file in the file explorer window. |
Description of the bug
when set the tool bar on the bottom, it happen to be displaced on editor and file explorer. but when switch it to button, it works very well. I do check the Console, it said like bellow:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getCommandFor') plugin:note-toolbar:129
at eval (plugin:note-toolbar:129:47846)
at Array.forEach ()
at Lo.displayToolbarList (plugin:note-toolbar:129:47673)
at Lo.display (plugin:note-toolbar:129:44960)
at SettingsSearch.getTabResources (plugin:settings-search:229:15)
at t.eval (plugin:settings-search:267:18)
at t.wrapper [as addSettingTab] (plugin:settings-search:59:20)
at Ko.addSettingTab (app.js:1:2260945)
at eval (plugin:note-toolbar:130:17322)
at t. (app.js:1:2223660)
eval @ plugin:note-toolbar:129
displayToolbarList @ plugin:note-toolbar:129
display @ plugin:note-toolbar:129
getTabResources @ plugin:settings-search:229
eval @ plugin:settings-search:267
wrapper @ plugin:settings-search:59
(anonymous) @ app.js:1
eval @ plugin:note-toolbar:130
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
a @ app.js:1
Steps to reproduce
Expected behavior
Screenshots (if you think it will help)
Video or a GIF would be appreciated.
Debug info:
Run "Show debug info" in Obsidian and paste it here (recommended). Alternately, fill out the sections below.
SYSTEM INFO:
Obsidian version: v1.8.9
Installer version: v1.8.9
Operating system: Darwin Kernel Version 24.3.0: Thu Jan 2 20:24:16 PST 2025; root:xnu-11215.81.4~3/RELEASE_ARM64_T6000 24.3.0
Login status: logged in
Language: zh
Catalyst license: none
Insider build toggle: off
Live preview: on
Base theme: adapt to system
Community theme: Minimal v7.7.18
Snippets enabled: 0
Restricted mode: off
Plugins installed: 46
Plugins enabled: 35
1: Excalidraw v2.8.3
2: Editing Toolbar v2.4.16
3: Easy Typing v5.5.11
4: Style Settings v1.0.9
5: Minimal Theme Settings v8.1.1
6: Settings Search v1.3.10
7: Commander v0.5.2
8: Custom Frames v2.5.0
9: Recent Files v1.7.4
10: Copilot v2.8.7
11: Advanced Tables v0.22.1
12: BRAT v1.0.6
13: Trash Explorer v1.2.3
14: AttachFlow v0.4.3
15: Comments v0.2.0
16: Mindmap NextGen v1.13.1
17: Iconize v2.14.7
18: Emoji Toolbar v0.4.1
19: Tasks v7.18.1
20: Thino v2.4.59
21: File Cleaner Redux v1.6.2
22: File Color v1.1.0
23: Global Search and Replace v0.5.0
24: Auto Reading Mode v1.0.4
25: File Info Panel v1.3
26: Tag Wrangler v0.6.1
27: Multi Properties v1.2.0
28: Projects v1.17.4
29: Image Converter v1.3.9
30: Image auto upload v4.1.0
31: Editor Width Slider v1.0.5
32: Linter v1.28.0
33: Note Toolbar v1.20.1
34: Templater v2.10.0
35: File Order v0.0.11
RECOMMENDATIONS:
Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
Plugin, Theme links, and CSS snippets (if applicable):
Plugins, themes, and CSS snippets can affect the display of the toolbar. Include any being used here to help diagnose display issues.
Desktop environment:
Mobile environment (if applicable to the issue):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: