Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IPBT interface to use bytes memory #23

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Update IPBT interface to use bytes memory #23

merged 1 commit into from
Oct 26, 2022

Conversation

cygaar
Copy link
Collaborator

@cygaar cygaar commented Oct 26, 2022

It doesn't make sense to use a bytes32 for the payload input because the payload can be of an arbitrary length. Additionally, in our isChipSignatureForToken implementation, we are converting the bytes32 to a bytes memory anyways, so we should just takes bytes memory as an input.

@cygaar cygaar requested a review from 2pmflow October 26, 2022 04:40
@cygaar cygaar merged commit b5f0e5f into main Oct 26, 2022
@cygaar cygaar deleted the update_interface branch October 26, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2pmflow 2pmflow 2pmflow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cygaar @2pmflow