Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace memo with forwardRef #355

Merged
merged 7 commits into from
Oct 5, 2020
Merged

Replace memo with forwardRef #355

merged 7 commits into from
Oct 5, 2020

Conversation

iwatakeshi
Copy link
Collaborator

@iwatakeshi iwatakeshi commented Oct 4, 2020 •
edited
Loading

Changes

@iwatakeshi iwatakeshi requested a review from chintan9 October 4, 2020 23:37
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 4, 2020
@vizipi
Copy link

vizipi bot commented Oct 4, 2020

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % Chintan Prajapati 99 5

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
rollup.config.js66.67 %2 out of 3 times
tsconfig.json66.67 %2 out of 3 times
src/index.ts66.67 %2 out of 3 times
.typo-ci.yml66.67 %2 out of 3 times
styleguide.config.js66.67 %2 out of 3 times

Committed file ranks

(click to expand)
  • 62.98%[src/Plyr.tsx]
  • 99.15%[package.json]
  • 22.13%[test/Plyr.test.tsx]
  • 99.57%[package-lock.json]
  • 98.72%[README.md]

    • sourcelevel-bot[bot]
    sourcelevel-bot bot reviewed Oct 5, 2020
    View reviewed changes
    README.md

    - [@iwatakeshi](https://github.com/iwatakeshi) For provide help for convert to typescript.
    - [@iwatakeshi](https://github.com/iwatakeshi) For provide help for convert to typescript.
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Incorrect list-item indent: add 2 spaces

    @iwatakeshi iwatakeshi mentioned this pull request Oct 5, 2020
    Closed
    chintan9
    chintan9 approved these changes Oct 5, 2020
    View reviewed changes
    Copy link
    Owner

    @chintan9 chintan9 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Oct 5, 2020
    @chintan9 chintan9 merged commit 909f719 into master Oct 5, 2020
    @trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Oct 5, 2020
    @chintan9 chintan9 linked an issue Oct 5, 2020 that may be closed by this pull request
    How to use player events like onplay #366
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @sourcelevel-bot sourcelevel-bot[bot] sourcelevel-bot[bot] left review comments

    @chintan9 chintan9 chintan9 approved these changes

    Assignees
    No one assigned
    Labels
    ✨ Merged Pull Request has been merged successfully size/M
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    How to use player events like onplay Using ref-property
    2 participants
    @iwatakeshi @chintan9