Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency to resolve security issue #1300

Merged
merged 2 commits into from
Apr 20, 2019
Merged

update dependency to resolve security issue #1300

merged 2 commits into from
Apr 20, 2019

Conversation

compilenix
Copy link

@compilenix compilenix changed the title update dependency: lodash to resolve security issue update dependency to resolve security issue Apr 17, 2019
@fb55 fb55 merged commit cce5c18 into cheeriojs:v1.0.0-rc.3 Apr 20, 2019
@fb55
Copy link
Member

fb55 commented Apr 20, 2019

Thanks!

@compilenix
Copy link
Author

One questtion @fb55 :
Would it be possible to add a package-lock.json any time soon?

Reference: #1199 (comment)

@fb55
Copy link
Member

fb55 commented Apr 21, 2019

Two reasons why it was removed: 1) They are hard to review and can point to random files on the internet, which I would consider a security risk and 2) similarly, dealing with merge conflicts is a pain.

@jugglinmike
Copy link
Member

I'm a little late to the party, but this patch was superfluous.

The Lodash vulnerability reported here was previously reported in gh-1175 and
subsequently fixed via gh-1179. The reason the fix was not available in
Cheerio's "rc3" release is that v1.0.0-rc.3 was created as a hotfix for
v1.0.0-rc.2--it does not have any of the changes which occured in master
since the second release candidate.

So while the next release of Cheerio will not include this commit, neither will
it include the vulnerable version of Lodash. In order to avoid further
confusion, I will delete the branch named v1.0.0-rc3. We will continue to
maintain the corresponding tag named 1.0.0-rc3 for the purposes of
archiving,

@jeroentvb jeroentvb mentioned this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants