Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HashStf #1558

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Remove HashStf #1558

merged 7 commits into from
Dec 5, 2024

Conversation

jfldde
Copy link
Contributor

@jfldde jfldde commented Dec 5, 2024

Description

  • Remove HashStf which was only used for init_and_restart full node test
  • Fixes get_l2_state_root return type which was failing serialization

Linked Issues

Testing

  • Replaced with e2e full_node restart test

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.1%. Comparing base (b610149) to head (2df5cdb).
Report is 1 commits behind head on nightly.

Additional details and impacted files
Files with missing lines Coverage Δ
...vereign-sdk/full-node/sov-ledger-rpc/src/client.rs 100.0% <ø> (ø)

... and 6 files with indirect coverage changes

@eyusufatik
Copy link
Member

one thing init_and_restart did different was that it tested if full node tried to run genesis in the second start. (bc it never synced to the sequencer). any chance you can capture the same in your test also?

Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yaziciahmet yaziciahmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfldde jfldde merged commit 7b3d816 into nightly Dec 5, 2024
14 of 15 checks passed
@jfldde jfldde deleted the remove-hash-stf branch December 5, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants