Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore short-prefix behind cargo flag #1554

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

jfldde
Copy link
Contributor

@jfldde jfldde commented Dec 4, 2024

Description

  • Restore short-prefix behind cargo short-prefix flag

Main rationale for the removal in #1537 was that compile time env was not properly propagated to risczero docker build. This restores it by propagating via cargo short-prefix flag, albeit in a convoluted way.

  • Automatically derive it when in running make test and make coverage
  • Remove the need to keep CI_TEST_MODE in line between build and test profiles.

Note that if for whatever reason, one is running via cargo test (not advised, make test is the recommended way) directly, additional --features short-prefix is needed in order not to have a mismatch in prefix length

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.1%. Comparing base (5d1eee6) to head (67d16f1).
Report is 1 commits behind head on nightly.

Additional details and impacted files

see 3 files with indirect coverage changes

@jfldde jfldde force-pushed the prefix-behind-testing-flag branch from ff7f3a0 to 67d16f1 Compare December 4, 2024 11:07
@jfldde jfldde merged commit b610149 into nightly Dec 4, 2024
14 of 15 checks passed
@jfldde jfldde deleted the prefix-behind-testing-flag branch December 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants