Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carry bitcoin-da tests to e2e #1515

Merged
merged 26 commits into from
Nov 26, 2024
Merged

Conversation

yaziciahmet
Copy link
Contributor

Description

Carry bitcoin-da tests to e2e test framework to avoid needing to maintain mock tx files existing under test_data directory, and being able to properly test all methods.

Linked Issues

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.3%. Comparing base (0494407) to head (0d39546).
Report is 1 commits behind head on nightly.

Additional details and impacted files
Files with missing lines Coverage Δ
crates/bitcoin-da/src/helpers/merkle_tree.rs 95.3% <100.0%> (+<0.1%) ⬆️
crates/bitcoin-da/src/helpers/mod.rs 80.0% <ø> (+6.0%) ⬆️
crates/bitcoin-da/src/helpers/parsers.rs 92.3% <ø> (+5.7%) ⬆️
crates/bitcoin-da/src/service.rs 72.7% <100.0%> (+28.3%) ⬆️
crates/bitcoin-da/src/verifier.rs 48.1% <100.0%> (-37.9%) ⬇️

... and 9 files with indirect coverage changes

@yaziciahmet yaziciahmet merged commit 61f962e into nightly Nov 26, 2024
14 of 15 checks passed
@yaziciahmet yaziciahmet deleted the yaziciahmet/e2e-bitcoin-da-tests branch November 26, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move bitcoin service and verifier tests to bitcoin-e2e
2 participants